[OpenWrt-Devel] [PATCH] fw3: robustify flow table detection.

Jo-Philipp Wich jo at mein.io
Thu Jan 23 03:32:35 EST 2020


> This doesn't seem right to me in case target > 12,
> MIN(sizeof(line), strlen(target)) perhaps?

a simple strcmp() without len will be the most appropriate since both
line (produced by fgets()) and target (a constant string literal) will
be \0 terminated.

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200123/509987e2/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list