[OpenWrt-Devel] [PATCH procd 0/4] fixes and improvements

Petr Štetiar ynezz at true.cz
Thu Jan 2 19:46:34 EST 2020


this series fixes out of tree build, failing image validation at least on
RPi-4 and reworks the firmware validation in order to fix following

 * unhandled read() errors
 * everything bundled in one long function, which is hard to follow and
   reason about
 * JSON parser errors are being ignored, anything else then
   json_tokener_continue is fatal error
 * JSON parser errors are being output to stderr, thus invisible via SSH
 * validate_firmware_image_call can fail at a lot of places, but we just
   get one generic "Firmware image couldn't be validated" so it's hard
   to debug

Petr Štetiar (4):
  cmake: fix lookup of external libraries
  system: fix failing image validation due to EINTR
  system: sysupgrade: rework firmware validation
  system: sysupgrade: fix possibly misleading error

 CMakeLists.txt          |  14 +++-
 system.c                | 173 ++++++++++++++++++++++++++++++----------
 upgraded/CMakeLists.txt |   2 +-
 3 files changed, 140 insertions(+), 49 deletions(-)

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list