[OpenWrt-Devel] [PATCH] build: refactor JSON info files

Petr Štetiar ynezz at true.cz
Fri Feb 28 18:41:11 EST 2020

Paul Spooren <mail at aparcar.org> [2020-02-28 13:09:46]:

> > > To archive the previous behaviour the option JSON_INDIVIDUAL_JSON_INFO
> > > can be set.
> > Why do we need to preserve that previous behaviour?
> Two reasons:
> * We have to create those files anyway before a merge because image creation
> happens in parallel, so no single overview can be added to. If this is a
> wrong assumption please step in

Ok, but we don't need two different config options for that. One for single
file JSON output and another one for amalgamated JSON.

> * For ImageBuilders it is convenient to have a per profile file.

I don't follow here.

> I'd be in favor of keeping it if you wouldn't mind. It would be disabled for
> buildbots and users per default.

I don't like an idea of having *two* different options for *one* functionality
for no reason. Initial idea was JSON for online builders, so thats *one* config
option to me.

> I'm looking into this issue but haven't figured it out yet. Either the JSON
> generation or file writing is broken. The odd thing about it is that it also
> happens if a file is opened only once (as in only a single image is
> created), so it is unlikely an issue with parallel writing into a file... If
> anyone has ideas, please share.

What about some graceful error handling, outputing the broken JSON file? Maybe
it's another Docker filesystem related hiccup?

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list