[OpenWrt-Devel] [PATCH 3/3] ath79: add support for Teltonika RUT955

[Adrian Schmutzler]

Hi,

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		signal0 {
> +			label = "rut955:green:signal1";

Still signalX not matching here.

> +			gpios = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
> +		};

[...]

> +
> +		led_system_green: system_green {
> +			label = "rut955:green:system";
> +			gpios = <&gpio_ext 6 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
> +			linux,default-trigger = "phy0tpt";

tpt trigger to the system LED? Don't think that would be really helpful, maybe
one can use one of the signal leds for that?

> +		};
> +	};
> +

[...]

> +define Build/teltonika-fw-fake-checksum
> +	# Teltonika U-Boot web based firmware upgrade/recovery routine
> compares
> +	# 16 bytes from md5sum1[16] field in TP-Link v1 header (offset: 76 bytes
> +	# from begin of the firmware file) with 16 bytes stored just before
> +	# 0xdeadc0de marker. Values are only compared, MD5 sum is not
> verified.
> +	let \
> +		offs="$$(stat -c%s $@) - 20"; \
> +		dd if=$@ bs=1 count=16 skip=76 |\
> +		dd of=$@ bs=1 count=16 seek=$$offs conv=notrunc

Maybe change to bs=16 count=1 for both? (Don't forget seek_bytes/skip_bytes
flags in this case.)

Best

Adrian



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel