[OpenWrt-Devel] [PATCH] ath79: introduces KERNEL_LZMA variable for common build sequence

Jo-Philipp Wich jo at mein.io
Mon Feb 3 05:23:32 EST 2020


what is the actual benefit of this? The image building recipes are hard enough
to understand as-is, is it really worth it to replace a plain "kernel-bin |
append-dtb | lzma" command sequence with yet another variable indirection just
to safe a few bytes in the Makefile?

I could understand the appeal of introducing a macro (or variable) if there's
a lot of repeated complex expressions in each KERNEL := ... recipe but that
isn't the case here.

If you really want to go down this route, then introducing an actual new build
step which aggregates the three steps into one would be cleaner imho.

Something similar to the following;

define Build/kernel-dtb-lzma
	$(call Build/kernel-bin)
	$(call Build/append-dtb)
	$(call Build/lzma)

And then

KERNEL := kernel-dtb-lzma | uImage lzma

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200203/d29d43af/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list