Please revert 98b86296e6 as it breaks several ipq806x devices

[Hannu Nyman]

Christian Lamparter kirjoitti 28.12.2020 klo 16.59:
> On 28/12/2020 15:27, Adrian Schmutzler wrote:
>>> -----Original Message-----
>>> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
>>> On Behalf Of Hannu Nyman
>>> Sent: Montag, 28. Dezember 2020 10:12
>>> To: OpenWrt Development List <openwrt-devel at lists.openwrt.org>
>>> Cc: Petr Štetiar <ynezz at true.cz>; Christian Lamparter
>>> <chunkeey at gmail.com>
>>> Subject: Please revert 98b86296e6 as it breaks several ipq806x devices
>>
>> https://github.com/openwrt/openwrt/commit/57e4cc8261ca6f0b32e4da6922a8f52ef82c4dc6 
>>
>>
>> This is meant as an emergency measure (thus no "Fixes"), and should be 
>> properly addressed at some point.
>>
>
> hmm, the R7800 must have some crazy bootargs-overrides when these
> impact sysupgrade as well. Let's hope there isn't an issue with
> the platform.sh + asrock.sh changes.
>
> @hannu: can you please post your R7800's /proc/device-tree/chosen/ files 
> (name + content)
> for reference?
>
> Cheers
> Christian


There aren't that many files (like Adrian already said).

This is the contents in r15359-2160a9d597 with that offending kernel symbol 
disabled:

root at router1:~# ls -l /proc/device-tree/chosen/
-r--r--r--    1 root     root             1 Dec 28 17:05 bootargs
-r--r--r--    1 root     root            25 Dec 28 17:05 bootloader-args
-r--r--r--    1 root     root             7 Dec 28 17:05 name
-r--r--r--    1 root     root            17 Dec 28 17:05 stdout-path

root at router1:~# cat /proc/device-tree/chosen/bootargs

root at router1:~# cat /proc/device-tree/chosen/bootloader-args
console=ttyHSL1,115200n8

root at router1:~# cat /proc/device-tree/chosen/name
chosen

root at router1:~# cat /proc/device-tree/chosen/stdout-path
serial0:115200n8


Also the cmdline in /proc is empty

root at router1:~# cat /proc/cmdline



Note that in the "normal" situation, the bootlog says that the 
bootloader-args get ignored:

[    0.000000] Bootloader command line (ignored): console=ttyHSL1,115200n8

Apparently the introduction and enabling of CONFIG_CMDLINE_OVERRIDE causes 
that faulty(?) line from bootloader-args to get applied, while it gets 
normally ignored.

No detailed idea why sysupgrade failed, but I suspect that it may somehow tie 
to the console tty being wrong.

I got first notified about that sysupgrade problem in forum discussion, and 
then yesterday I tested it by myself.
A few messages at https://forum.openwrt.org/t/build-for-netgear-r7800/316/2753

I would need to reflash a faulty build to see the problem again more 
closely...  (But that would only make sense if you have good ideas how/what 
to debug without serial console)