Please revert 98b86296e6 as it breaks several ipq806x devices

Hannu Nyman hannu.nyman at iki.fi
Mon Dec 28 04:11:37 EST 2020


Please revert commit 98b86296e6 "ipq806x: add support for ASRock G10" as it 
breaks several popular ipq806x devices.

98b86296e6 adds a new kernel config symbol CONFIG_CMDLINE_OVERRIDE for 
ipq806x and enables it for all ipq806x devices.

Based on forum discussion and my own experience, that new symbol apparently 
changes the kernel command line and breaks several ipq806x devices. Either 
the devices do not boot or there are other symptoms.


Symptoms in my own R7800:

* serial console is disabled. It works during u-boot but is silent after 
kernel takes over  (as console gets assigned to wrong tty)

* sysupgrade FROM builds with commit 98b86296e6 included does not work. 
Debugging that is not feasible, as serial console is broken...



Bug report in:

https://bugs.openwrt.org/index.php?do=details&task_id=3540

and in

https://github.com/openwrt/openwrt/commit/98b86296e67dd2b467212fe1a577656e6d3725da#commitcomment-45455875


Things get fixed by reverting the kernel symbol part from 98b86296e6:


|--- a/target/linux/ipq806x/config-5.4 +++ b/target/linux/ipq806x/config-5.4 
@@ -78,7 +78,7 @@ CONFIG_CC_HAS_KASAN_GENERIC=y CONFIG_CLKDEV_LOOKUP=y 
CONFIG_CLKSRC_QCOM=y CONFIG_CLONE_BACKWARDS=y -CONFIG_CMDLINE_OVERRIDE=y +# 
CONFIG_CMDLINE_OVERRIDE is not set CONFIG_COMMON_CLK=y 
CONFIG_COMMON_CLK_QCOM=y CONFIG_COMPAT_32BIT_TIME=y|






More information about the openwrt-devel mailing list