[PATCH 3/3] ramips: add RT6855A SoC Linux support patches

Chuanhong Guo gch981213 at gmail.com
Wed Dec 23 21:12:16 EST 2020


Hi!

On Thu, Dec 24, 2020 at 12:52 AM Rafaël Carré <funman at videolan.org> wrote:
>
> TODO: the spi-mt7621 patches will break support for other targets

Does that work on RT6855A at all? spi-mt7621 is a mediatek IP core.
For a Ralink SoC I'm expected to see a controller supported by
existing spi-ralink.c instead.
The GPL code you linked in one of your patch only contains
the driver for the ralink spi controller and I can't find the mt7621
driver (ralink_spi_bbu.c) at all.
And please try your best to finish the TODOs before sending
them for review. Or send it as RFC instead.
I'm marking this patch rejected for the exact reasons you've
realized yourself in those TODOs:
1. adding the old vendor pci drivers
2. breaking the spi driver for mt7621/mt7628.

Regards,
Chuanhong Guo



More information about the openwrt-devel mailing list