[PATCH uclient 06/12] uclient: fix initialized but never read variable

Petr Štetiar ynezz at true.cz
Thu Dec 10 10:47:53 EST 2020


Fixes following issue reported by clang-12 static analyzer:

 uclient.c:290:22: warning: Value stored to 'url' during its initialization is never read [deadcode.DeadStores]
         struct uclient_url *url = cl->url;
                             ^~~   ~~~~~~~

Signed-off-by: Petr Štetiar <ynezz at true.cz>
---
 uclient.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uclient.c b/uclient.c
index 95e4585a61cf..a372d4a9dcbf 100644
--- a/uclient.c
+++ b/uclient.c
@@ -287,7 +287,7 @@ int uclient_set_proxy_url(struct uclient *cl, const char *url_str, const char *a
 int uclient_set_url(struct uclient *cl, const char *url_str, const char *auth_str)
 {
 	const struct uclient_backend *backend = cl->backend;
-	struct uclient_url *url = cl->url;
+	struct uclient_url *url;
 
 	url = uclient_get_url(url_str, auth_str);
 	if (!url)



More information about the openwrt-devel mailing list