[PATCH 1/2] ipq40xx: add support for Luma WRTQ-329ACN

[Adrian Schmutzler]

Hi,

> +	DEVICE_VENDOR := Luma
> +	DEVICE_MODEL := Home (WRTQ-329ACN)

If you use WRTQ-329ACN as the primary name for OpenWrt here (as in device definition, compatible), I'd also put it first here and have the "Home" in brackets.
Apart from that, I'd make DEVICE_VENDOR/DEVICE_MODEL consistent with the DTS, so add the "Home" in brackets there, too.
 
> +	SOC := qcom-ipq4018
> +	DEVICE_DTS := qcom-ipq4018-wrtq-329acn

DEVICE_DTS can be dropped, it should be calculated from SOC and device name.

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200828/a9b52ca7/attachment-0001.sig>