[PATCH 3/3] toolchain: remove BROKEN from uClibc-ng

[Rosen Penev]

On Sat, Aug 15, 2020 at 9:49 PM Felix Fietkau <nbd at nbd.name> wrote:
>
> On 2020-08-16 00:27, Rosen Penev wrote:
> > On Sat, Aug 15, 2020 at 2:02 AM Felix Fietkau <nbd at nbd.name> wrote:
> >>
> >> On 2020-08-14 23:30, Rosen Penev wrote:
> >> > uClibc-ng works fine. Additionally, most packages have been fixed to
> >> > compile with uClibc-ng.
> >> >
> >> > Signed-off-by: Rosen Penev <rosenp at gmail.com>
> >> It does not make sense to maintain uClibc-ng for anything other than arc
> >> (the only arch that needs it). In fact, once arc is switched to glibc,
> >> we should remove uClibc-ng entirely.
> > My opinion is that it's fairly useful for testing purposes.
> >
> > More to the patch, there's nothing broken about uClibc-ng.
> "testing purposes" is exactly why the dependency says
> "depends on BROKEN || arc" instead of "depends on !arc"
BROKEN implies that something is broken about it, which is not true.

The main motivation behind this patch is that enabling "Enable broken
packages" in Advanced Options ends up enabling actual broken packages
in my .config which is not what I want.
>
> This makes it clear that it's an unsupported configuration, but it still
> allows you to enable it with a few more steps.
>
> I guess a way to make it even more clear would be to introduce an
> 'UNSUPPORTED' config symbol to distinguish it from 'BROKEN', but I'm not
> sure if it's worth adding.
Probably not. For someone to enable uClibc-ng, they would need to
enable Advanced Options. Most of the options there are for testing
purposes anyway...
>
> - Felix