[PATCH v3 0/4] Granular timestamps in packages

Paul Spooren mail at aparcar.org
Sat Aug 15 16:56:59 EDT 2020


v3: Fix subshell exit. I wan't aware that () cretes a subshell with it's
	own exit code, now it relly exists. Also break long line (>80)
	down so checkpatch.pl is happy.

v2: Fix Shellcheck patch which would exit if TOPDIR isn't definied.
	Instead it should just exit if TOPDIR is defined but the `cd`
	fails.

Based on Jo's IRC statement below[1] I reworked the get_source_date_epoch
script to create reproducible builds even if the SDK is updated.

<jow> aparcar: I investigated that pacakge reproducibility issue a
	little bit
<jow> the problem is twofold
<jow> 1) ipkg-bild uses SOURCE_DATE_EPOCH which - in the
	case of SDK - is hardcoded to the SDK build time

This should fix part 1. HG is untested and I'd prefer to just remove it
from the script, it doesn't seem to be used anywhere anyway.

<jow> 2) depending on toolchain version etc. building
	the same package sources might generate different binaries (this
	seems to be the lesser problem atm)

Part 2 will be tackled in some later patches.

[1]: http://logs.nslu2-linux.org/livelogs/openwrt-devel/openwrt-devel.20200807.txt

Paul Spooren (4):
  build: Fix Shellcheck for get_source_date_epoch.sh
  build: get_source_date_epoch allow external repos
  build: store granular timestamps in packages
  build: store SourceDateEpoch in manifest

 include/package-ipkg.mk          |  2 ++
 package/Makefile                 |  2 +-
 scripts/get_source_date_epoch.sh | 21 +++++++++++++--------
 scripts/ipkg-build               | 12 +++---------
 4 files changed, 19 insertions(+), 18 deletions(-)

-- 
2.25.1




More information about the openwrt-devel mailing list