[PATCH] ath79: add support for ALLNET ALL-WAP02860AC

[Adrian Schmutzler]

> -----Original Message-----
> From: Tomasz Maciej Nowak [mailto:tomek_n at o2.pl]
> Sent: Freitag, 14. August 2020 18:55
> To: Adrian Schmutzler <mail at adrianschmutzler.de>; openwrt-
> devel at lists.openwrt.org
> Subject: Re: [PATCH] ath79: add support for ALLNET ALL-WAP02860AC
> 
> Hi,
> W dniu 14.08.2020 o 18:30, Adrian Schmutzler pisze:
> > Hi,
> >
> >> +&wmac {
> >> +	status = "okay";
> >> +
> >> +	mtd-cal-data = <&art 0x1000>;
> >> +	mtd-mac-address = <&art 0x0>;
> >> +	mtd-mac-address-increment = <1>;
> >
> > Caldata does not contain valid addresses? (same for 0x5000)
> 
> Nope.
> 
> >
> > Are the calculated addresses chosen in accordance with OEM firmware?
> 
> Yes.
> 
> Should I move the caldata extraction and MAC address setting to userspace?

I think it's fine how it's done now (if you checked it's actually working for the caldata).

I will have a closer look later and then apply it if nothing new comes up (probably I will add a sentence that MAC addresses are following OEM firmware to the commit message).

Best

Adrian

> 
> >
> > Rest seems fine on a quick look.
> >
> > Best
> >
> > Adrian
> >
> 
> Regards
> 
> --
> TMN
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200814/58f34830/attachment.sig>