ath25 and rb532 fail after mac80211 changes

Adrian Schmutzler mail at adrianschmutzler.de
Fri Aug 14 05:16:13 EDT 2020


Hi,

after "mac80211: merge performance improvement patches" [1], build fails on a few 4.14 targets, namely ath25, rb532 (and ar71xx):

/builder/shared-workdir/build/build_dir/target-mips_mips32_musl/linux-ath25/backports-5.8-1/net/mac80211/rx.c:4803:3: error: implicit declaration of function 'netif_receive_skb_list'; did you mean 'netif_receive_skb'? [-Werror=implicit-function-declaration]
   netif_receive_skb_list(&list);
   ^~~~~~~~~~~~~~~~~~~~~~
   netif_receive_skb
/builder/shared-workdir/build/build_dir/target-mips_mips32_musl/linux-ath25/backports-5.8-1/net/mac80211/rx.c:4808:3: error: implicit declaration of function 'skb_list_del_init'; did you mean 'hlist_del_init'? [-Werror=implicit-function-declaration]
   skb_list_del_init(skb);
   ^~~~~~~~~~~~~~~~~
   hlist_del_init

scripts/Makefile.build:326: recipe for target '/builder/shared-workdir/build/build_dir/target-mips_mips32_musl/linux-ath25/backports-5.8-1/net/mac80211/rx.o' failed
make[8]: *** [/builder/shared-workdir/build/build_dir/target-mips_mips32_musl/linux-ath25/backports-5.8-1/net/mac80211/rx.o] Error 1
scripts/Makefile.build:585: recipe for target '/builder/shared-workdir/build/build_dir/target-mips_mips32_musl/linux-ath25/backports-5.8-1/net/mac80211' failed
make[7]: *** [/builder/shared-workdir/build/build_dir/target-mips_mips32_musl/linux-ath25/backports-5.8-1/net/mac80211] Error 2


So, we have to decide whether
1. we fix this
2. we leave the buildbots broken
3. we remove those 4.14 targets in master (ath25, rb532)

Personally, I prefer option 3, as it's only a matter of time when we drop those targets anyway.

Best

Adrian

[1] https://github.com/openwrt/openwrt/commit/3d731fc9030655e18d86f81ca8aed3341ab2bc1e
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200814/082815e1/attachment.sig>


More information about the openwrt-devel mailing list