[PATCH 4/4] build: remove INSTALL_SUID

[Paul Spooren]

On 07.08.20 11:13, Paul Spooren wrote:
> Instead of INSTALL_SUID the PKG_FILE_MODES variable should be used
>
> Signed-off-by: Paul Spooren <mail at aparcar.org>
> ---
>   rules.mk | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/rules.mk b/rules.mk
> index 45d96d6be4..d535e57266 100644
> --- a/rules.mk
> +++ b/rules.mk
> @@ -281,7 +281,6 @@ PATCH:=patch
>   PYTHON:=python
>   
>   INSTALL_BIN:=install -m0755
> -INSTALL_SUID:=install -m4755
>   INSTALL_DIR:=install -d -m0755
>   INSTALL_DATA:=install -m0644
>   INSTALL_CONF:=install -m0600

I just checked packages.git and they still use it for multiple binaries. 
Therefore this shouldn't be merged at once, but only as a follow up once 
the packages in packages.git are updated.

user at dawn:~/src/openwrt/packages$ rg INSTALL_SUID
admin/schroot/Makefile
70:    $(INSTALL_SUID) $(PKG_INSTALL_DIR)/usr/bin/schroot $(1)/usr/bin/

utils/mariadb/Makefile
556:      $(INSTALL_SUID) \

net/iputils/Makefile
67:    $(INSTALL_SUID) $(MESON_BUILD_DIR)/ping $(1)/usr/bin/

net/fping/Makefile
49:    $(INSTALL_SUID) $(PKG_INSTALL_DIR)/usr/sbin/fping $(1)/usr/bin/

net/apache/Makefile
331:    $(INSTALL_SUID) $(PKG_INSTALL_DIR)/usr/sbin/suexec \