[PATCH v2 3/3] apm821xx: set DEVICE_TYPE to "nas" for sata subtarget

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij at linaro.org]
> Sent: Donnerstag, 6. August 2020 16:57
> To: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> Cc: OpenWrt Development List <openwrt-devel at lists.openwrt.org>;
> Christian Lamparter <chunkeey at gmail.com>; Sungbo Eo
> <mans0n at gorani.run>
> Subject: Re: [PATCH v2 3/3] apm821xx: set DEVICE_TYPE to "nas" for sata
> subtarget
> 
> Hi Adrian,
> 
> I got back to trying to fix the NAS packages for the Gemini.
> 
> On Sat, May 30, 2020 at 11:29 AM Adrian Schmutzler
> <freifunk at adrianschmutzler.de> wrote:
> 
> > Since DEVICE_TYPE cannot be set per device, just set DEVICE_TYPE to
> > "nas" for the entire subtarget, which only contains this single
> > device.
> >
> > Note that while this looks like a cosmetic change in combination with
> > the previous patches, this particular patch actually changes the
> > packages for the device.
> >
> > Suggested-by: Christian Lamparter <chunkeey at gmail.com>
> > Cc: Christian Lamparter <chunkeey at gmail.com>
> > Cc: Sungbo Eo <mans0n at gorani.run>
> > Cc: Linus Walleij <linus.walleij at linaro.org>
> > Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> 
> So if I understand correctly, what I need to do it to split Gemini into
> subtargets (such as "boots from flash" and "boots from harddisk") like the
> APM does, so I can establish two profiles, and then that means I can also split
> the Makefile for the images like the APM does?

the question is what's your goal at the end. Just taking care of adding/removing packages can be done for the device individually without touching DEVICE_TYPE at all.

Switching parameters in packages based on a DEVICE_TYPE will be another story, I remember that Matthias said it currently was broken anyway IIRC.

We would technically also still have the option to make DEVICE_TYPE a real per-device variable, but then this would only work for package _selection_ again.

If you really desire to change package config stuff, you will indeed need a "NAS" subtarget then. And then you'd still have to check whether the package is really built "per-subtarget", and not just per arch or similar ...

So, as you see, it's hard to discuss this in general, but we would need to base the discussion on the individual packages affected.

Best

Adrian

> 
> Yours,
> Linus Walleij
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200806/98a2bfb5/attachment.sig>