your mail

[Daniel Golle]

On Sun, Aug 02, 2020 at 07:49:40PM -0300, SAn via openwrt-devel wrote:
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.

> Date: Sun, 2 Aug 2020 19:49:40 -0300
> From: SAn <spiccinini at altermundi.net>
> To: openwrt-devel at lists.openwrt.org
> Subject: ath79 subtarget with cmdline from bootloader
> 
> Hi! 
> 
> The LibreRouter uses a dual-boot scheme that relies on the bootloader configuring the kernel cmdline. At ar71xx 18.06 it was possible to select per device if the cmdline from the bootloader has to be honored (using patch-cmdline).
> AFAIK there is no such possibility on ath79.
> 
> Would you consider accepting a patch that adds a new ath79 subtarget with CONFIG_MIPS_CMDLINE_FROM_BOOTLOADER (or CONFIG_MIPS_CMDLINE_BUILTIN_EXTEND)?
> 
> It would be valuable for the people using LibreRouter devices to be able to use official OpenWrt 20.xx images with the dual-boot support. Currently there are multiple mips targets that use CONFIG_MIPS_CMDLINE_FROM_BOOTLOADER (bcm47xx, octeon, malta, and a few more).

I don't think this justifies an extra subtarget just for the sake of
having the kernel process cmdline arguments passed by an outdated
(ie. non-DT, non-FIT) bootloader.
If it really has to be that way (and eg. parsing uboot-env cannot be
used instead and bootloader cannot be updated to properly pass this
in dtb), I guess something along the lines of
CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_MANGLE
could work (would have to be implemented for MIPS first, obviously).

Alternatively, as a quick-and-dirty workaround, just move the whole
librerouter.dts into a .dtsi and then have two .dts files referecing
them, each setting different cmdline. Then generate two images.
That'd be the same effect as what patch-cmdline used to do on non-DT
targets.