[OpenWrt-Devel] [PATCH] build: config: allow bool to select a module pkg

[Hannu Nyman]

Eneas U de Queiroz wrote at Thu Apr 9 17:39:17 PDT 2020:
 > This was reported to me here:
 > 
https://github.com/openwrt/openwrt/commit/dcf3e63a35d05e7e5103819c0f17195bfafe9baa#commitcomment-38390450
 > The update to kconfig-v5.6 broke TARGET_MULTI_PROFILE because it would not 
accept bool TARGET_DEVICE_<dev> to select MODULE_DEFAULT_<pkg> because 
MODULE_DEFAULT_<pgk> 'depends on m'--should only have a 'n' or 'm' value.  A 
'y' value would imply an unmet direct dependency (depends on m).
 >
 > My first thought was OK, if it wants to be a 'y', get rid of the 'depends 
on m' line; that did not work, because MODULE_DEFAULT_<pkg> selects 
PACKAGE_pkg, then <pkg> would be forced to be built-in.
 > So, unless someone has a better idea, let's revert to the old behavior, 
and tolerate some 'unmet dependencies' once again.

Hopefully this gets fixed soon, as I have a hunch that this broke pretty much 
all TARGET_MULTI_PROFILE builds that have varying key components (like wifi 
firmware). Possibly also buildbot snapshots, as e.g. in ipq806x the included 
wifi firmware file varies by device.

I noticed a problem with my own multi-device builds, and there is now forum 
dicsussion about an issue, which I think is related to this:
https://forum.openwrt.org/t/wireless-fails-on-snapshot-r12900-kernel-5-4-on-c2600-ipq806x/60155/1

Applying the patch propsed here helped to fix my ath79 multi-device build.



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel