[OpenWrt-Devel] [PATCH] bcm53xx: tidy up board.d/02_network even further

Rafał Miłecki rafal at milecki.pl
Fri Apr 3 17:15:20 EDT 2020


On 03.04.2020 21:29, Adrian Schmutzler wrote:
> This arranges the code in 02_network to resemble the structure using
> lan_macaddr and wan_macaddr variables like in other targets as close
> as possible (without becoming non-cosmetic).

I'm sorry but I'm starring at it and I see hardly any improvement.

Maybe this makes code more similar to one from target <foo> but I don't
see why it's better to have both ucidef_set_interface_macaddr() calls
at the end of function. I'd say it's a matter of personal preference.

The old variable name "etXmacaddr" matches closely NVRAM variable names
(et0macaddr, et1macaddr and et2macaddr) so I don't see why changing it
to "etX_macaddr" would make code necessarily better. If we start doing
such changes we'll keep changing code like that over and over.

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list