[OpenWrt-Devel] [PATCH] mvebu, tegra: make CPU subtype default to vfp3-d16
ynezz at true.cz
Wed Apr 1 09:52:29 EDT 2020
Christian Lamparter <chunkeey at gmail.com> [2020-04-01 15:43:40]:
> > > diff --git a/include/target.mk b/include/target.mk
> > > index 9bd4c14936c1..94ea1a9e0001 100644
> > > --- a/include/target.mk
> > > +++ b/include/target.mk
> > > @@ -179,6 +179,9 @@ ifeq ($(DUMP),1)
> > > endif
> > > ifneq ($(findstring arm,$(ARCH)),)
> > > CPU_TYPE ?= xscale
> > > + ifeq ($(CONFIG_SOFT_FLOAT),)
> > > + CPU_CFLAGS_vfpv3 = -mfpu=vfpv3-d16
> > > + endif
> The question I'm pondering is: Do you really want to maintain this specifc maps
> for this (only this arch) or not?
Ideally no, sure, but I wasn't aware about the other options. I don't own HW
with this CPUs, so have no prior experience.
> Because I do think this will creep up sooner or later again.
Yeah, thats likely going to happen :-)
> So we could also defuse this a bit by replacing that monicer "vfpv3" (as
> this is a gcc/binutils thing and not under our control) with something
> "clearly from OpenWrt". like CPU_CFLAGS_fpu = -mfpu=vfpv3-d16 (if that
> doesn't clash with something else).
You mean put this explicitly in the target/linux/tegra/Makefile?
> But then again, I'm not here to tell you what to do.
I'm all in to fix this properly.
> If you want your patch as-is then go for it! :D
Then I would commit it without even asking for review, right? :-)
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel