[OpenWrt-Devel] [PATCH 1/3] ramips/mt762x: convert devices to interrupt-driven gpio-keys

Adrian Schmutzler mail at adrianschmutzler.de
Fri Sep 20 05:54:27 EDT 2019


> -----Original Message-----
> From: Petr Štetiar [mailto:ynezz at true.cz]
> Sent: Freitag, 20. September 2019 08:45
> To: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> Cc: openwrt-devel at lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH 1/3] ramips/mt762x: convert devices to interrupt-driven gpio-keys
> Adrian Schmutzler <freifunk at adrianschmutzler.de> [2019-09-17 14:22:21]:
> Hi,
> > This converts all remaining devices to use interrupt-driven
> > gpio-keys compatible instead of gpio-keys-polled.
> > The poll-interval is removed.
> [...]
> >  161 files changed, 197 insertions(+), 314 deletions(-)
> I'm just wondering what makes you so confident, that this changes wont break
> any of the affected devices. On which devices this has been tested? Some
> Tested-by: would help to get this merged, thanks.

Well, for quite some time already every device added to ath79 and ramips has been advised to use gpio-keys, and I personally do not remember a single case where issues with that have been reported (that were not also present with polled keys).

Also note that I only address mt762x devices here, and do not touch the rtxxxx subtargets.

But I would obviously also be happy about some Tested-by from the list (as with ath79, where I received those).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190920/6038972e/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list