[OpenWrt-Devel] [PATCH] base-files: fix get_mac_address not accepting hex offsets

mail at adrianschmutzler.de mail at adrianschmutzler.de
Wed Sep 4 16:08:08 EDT 2019


> -----Original Message----- 
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org] 
> On Behalf Of David Bauer 
> Sent: Mittwoch, 4. September 2019 21:19 
> To: openwrt-devel at lists.openwrt.org 
> Cc: mail at adrianschmutzler.de 
> Subject: [OpenWrt-Devel] [PATCH] base-files: fix get_mac_address not 
> accepting hex offsets 
> The get_mac_address helper methods did not support hexadecimal offset 
> values, resulting them to break after 75bfc393ba6c ("treewide: 
> convert MAC address location offsets to hexadecimal") 

when I tested it then, the hexdump offset did accept hexadecimal values intrinsically. 
I remember that because I was quite surprised that offset accepted hexadecimal values and size didn't. 

In particular I've always been using get_mac_binary with hexadecimal values as second argument. 
Or am I misunderstanding you somewhere? 

However, converting it as in this patch doesn't hurt, especially if the behavior of hexdump changes in the future. 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190904/ae3357a4/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190904/ae3357a4/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list