[OpenWrt-Devel] [PATCH] hostapd: add IEEE 802.11k support

[Petr Štetiar]

Kyle Copperfield via openwrt-devel <openwrt-devel at lists.openwrt.org> [2019-10-31 06:50:55]:

Hi,

you should fix your mail setup:

> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.

as a next step, please kindly read https://openwrt.org/submitting-patches one
more time and fix your patch accordingly.

> Add IEEE802.11k neighbor and beacon report

 "commit description: it should explain to a competent reader why you made this commit."

>  Original patch by Lorenzo Santina @BigNerd95 on GH
>  <lorenzo.santina at edu.unito.it>

  From https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

 "Co-developed-by: states that the patch was co-created by multiple
  developers; it is a used to give attribution to co-authors (in addition to the
  author attributed by the From: tag) when several people work on a single
  patch. Since Co-developed-by: denotes authorship, every Co-developed-by: must
  be immediately followed by a Signed-off-by: of the associated co-author.
  Standard sign-off procedure applies, i.e. the ordering of Signed-off-by: tags
  should reflect the chronological history of the patch insofar as possible,
  regardless of whether the author is attributed via From: or Co-developed-by:.
  Notably, the last Signed-off-by: must always be that of the developer
  submitting the patch."

>  Original patch by Lorenzo Santina @BigNerd95 on GH

GH -> simply add 'Ref: http://some/url' tag.

And one very important one:

 "all commits must contain Signed-off-by: My Name <my at email.address> where you
  write your real name and real email address!

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel