[OpenWrt-Devel] [PATCH 1/2] ath79: add support for Netgear WNDR4300

[Adrian Schmutzler]

Hi,

just some MAC related comments below:

> @@ -403,6 +404,10 @@ ath79_setup_macs()
>  	netgear,wndr3800)
>  		lan_mac=$(macaddr_setbit_la "$(mtd_get_mac_binary art 0x0)")
>  		;;
> +	netgear,wndr4300)
> +		lan_mac=$(mtd_get_mac_binary caldata 0x0)
> +		wan_mac=$(mtd_get_mac_binary caldata 0x6)
> +		;;

lan_mac should be removed here. You already set mtd-mac-address in dts.

> +&wmac {
> +	status = "okay";
> +
> +	mtd-mac-address = <&art 0x0>;
> +	qca,no-eeprom;
> +};
> +
> +&pcie {
> +	status = "okay";
> +
> +	ath9k: wifi at 0,0 {
> +		compatible = "pci168c,0033";
> +		reg = <0x0000 0 0 0 0>;
> +		mtd-mac-address = <&art 0xc>;

This order of addresses looks a litte uncommon. Have you verified it against stock firmware?

lan art 0x0
wan art 0x6
2.4 GHz art 0x0
5 GHz art 0xc

Have you checked that there are no usable addresses in 0x1002 and 0x5006?

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191011/26a92444/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel