[OpenWrt-Devel] [PATCH] base-files: add /usr/share/libubox/jshn.sh to sysupgrade stage2

[Russell Senior]

It should be harmless.

+1

On Wed, Nov 13, 2019 at 3:22 PM <mail at adrianschmutzler.de> wrote:

> Hi,
>
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> > On Behalf Of Russell Senior
> > Sent: Donnerstag, 14. November 2019 00:16
> > To: Daniel Golle <daniel at makrotopia.org>
> > Cc: openwrt-devel at lists.openwrt.org
> > Subject: Re: [OpenWrt-Devel] [PATCH] base-files: add
> > /usr/share/libubox/jshn.sh to sysupgrade stage2
> >
> > >>>>> "Daniel" == Daniel Golle <daniel at makrotopia.org> writes:
> >
> > Daniel> Hi Russell,
> > Daniel> On Tue, Nov 12, 2019 at 03:33:48PM -0800, Russell Senior wrote:
> > >>
> > >> Discovered recent changes had broken sysupgrade for ar71xx mikrotik
> > >> rb-493g, traced the problem to missing /usr/share/libubox/jshn.sh
> > >> after switching to tmpfs.
> >
> > Daniel> I've applied your patch to master. Do we need to apply it for
> > Daniel> openwrt-19.07 as well?
> >
> > I'm not sure, I haven't tested 19.07.
>
> I think most of the sysupgrade changes have been backported. Despite, we
> are fixing ar71xx here, it makes no sense to fix ar71xx in master only ...
> And adding a file should not break anything, in worst case the file would
> be just useless?
>
> So, I'd vote for backport.
>
> Best
>
> Adrian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191113/16351908/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel