[OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"
rosenp at gmail.com
Fri Nov 1 15:06:39 EDT 2019
On Fri, Nov 1, 2019 at 2:21 AM Jo-Philipp Wich <jo at mein.io> wrote:
> > Removing this directory from TARGET_CPPFLAGS will cut down the log noise
> > a bit. Not only will CPPFLAGS be shorter, there will be less warnings
> > set off by "-Wmissing-include-dirs" (or even failures when paired with
> > "-Werror"). After all the directory does not even _exist_ in the SDKs,
> > which are used on the build bots when building packages (see  and
> > ).
Would it also make sense to remove $(STAGING_DIR)/lib ? Locally, it
seems libpam gets installed there (probably a bug).
> > Signed-off-by: Sebastian Kemper <sebastian_ml at gmx.net>
> Acked-by: Jo-Philipp Wich <jo at mein.io>
> I wanted to look into this for a long time but never had the motivation
> to actually do comprehensive tests of the impacts of the removal.
> So, thanks for looking into that - its fine from my side.
> ~ Jo
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel