[OpenWrt-Devel] [PATCH] ath79: Add support for ZBT-WD323

[Petr Štetiar]

Kristian Evensen <kristian.evensen at gmail.com> [2019-05-20 20:07:32]:

Hi,

> +zbtlink,zbt-wd323)
> +	ucidef_set_led_wlan "wlan" "WLAN" "$boardname:green:wifi" "phy0tpt"
> +	;;
>  esac

Please add this trigger to the DTS.

> +#include "ar9344.dtsi"
> +	compatible = "zbtlink,zbt-wd323", "qca,ar9334";

Is it really ar9334 ?

> +	aliases {
> +		serial0 = &uart;
> +	};

Why do you need this alias? Does it work without it? ar9344 has ns16550a UART
which doesn't need this alias.

> +	keys {
> +		compatible = "gpio-keys-polled";

Does it work for you with "gpio-keys" compatible? It's interrupt driven, so
should be preferred.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel