[OpenWrt-Devel] Build system puzzles: PCI_SUPPORT not being set for subtarget

Jeff Kletsky lede at allycomm.com
Thu May 9 12:25:33 EDT 2019 

On 5/9/19 12:04 PM, Petr Štetiar wrote:

> Jeff Kletsky <lede at allycomm.com> [2019-05-09 11:23:18]:
>
>> I reconfirmed that
>>
>>    openwrt/target/linux/ath79$ cp generic/config-default nand/config-default
>>    openwrt$ cat /dev/null > .config
>>    openwrt$ make menuconfig
>>
>> has the same behavior -- the nand target does not set PCI_SUPPORT
> it works here(tm):
>
>   CONFIG_TARGET_ath79=y
>   CONFIG_TARGET_ath79_nand=y
>   CONFIG_TARGET_ath79_nand_DEVICE_glinet_gl-ar300m-nand=y
>   CONFIG_ATH10K-CT_LEDS=y
>   CONFIG_DRIVER_11AC_SUPPORT=y
>   CONFIG_PACKAGE_kmod-ath10k-ct=y
>   CONFIG_PACKAGE_kmod-hwmon-core=y
>
> -- ynezz

What I'm seeing is that ath10k gets stripped out for nand,
but not for nor. I ran "virgin" tests with the scripts below,
with the same config-default in both generic/ and nand/.

Perhaps I am missing something or misunderstood, but below
is what I'm seeing with what I interpreted as .config seed above.

Both

   # CONFIG_PACKAGE_kmod-ath10k is not set
   CONFIG_PACKAGE_kmod-ath10k-ct=y

are missing for the nand subtarget.


I'm willing to track this down (as I've got an AR750S
running on NAND, including sysupgrade), but at least so far
I haven't been successful in getting output from
scripts/kconfig.pl to confirm that it is what is generating
the config from the various pieces at the generic-Linux, target,
and subtarget levels. Is there a different place I should
be looking?


Jeff



glinet_gl-ar300m-nor
--------------------

CONFIG_PACKAGE_kmod-ath10k-ct=y


=====

'target/linux/ath79/generic/config-default' -> 'target/linux/ath79/nand/config-default'
Collecting package info: done
configuration written to .config

*** End of the configuration.
*** Execute 'make' to start the build or try 'make help'.

# ath10k IPQ4019 Boarddata
# CONFIG_PACKAGE_ath10k-firmware-qca4019 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca4019-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca4019-ct-htt is not set
# CONFIG_PACKAGE_ath10k-firmware-qca6174 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9887 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9887-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9887-ct-htt is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9888 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9888-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9888-ct-htt is not set
# CONFIG_PACKAGE_ath10k-firmware-qca988x is not set
# CONFIG_PACKAGE_ath10k-firmware-qca988x-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca988x-ct-htt is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9984 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9984-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9984-ct-htt is not set
# CONFIG_PACKAGE_ath10k-firmware-qca99x0 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca99x0-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca99x0-ct-htt is not set
# CONFIG_PACKAGE_kmod-ath10k is not set
CONFIG_PACKAGE_kmod-ath10k-ct=y



glinet_gl-ar300m-nand
---------------------

CONFIG_PACKAGE_kmod-ath10k-ct=y


=====

'target/linux/ath79/generic/config-default' -> 'target/linux/ath79/nand/config-default'
Collecting package info: done
configuration written to .config

*** End of the configuration.
*** Execute 'make' to start the build or try 'make help'.

# ath10k IPQ4019 Boarddata
# CONFIG_PACKAGE_ath10k-firmware-qca4019 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca4019-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca6174 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9887 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9887-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9888 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9888-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca988x is not set
# CONFIG_PACKAGE_ath10k-firmware-qca988x-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9984 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca9984-ct is not set
# CONFIG_PACKAGE_ath10k-firmware-qca99x0 is not set
# CONFIG_PACKAGE_ath10k-firmware-qca99x0-ct is not set



Scripts to replicate:

test-nor.sh
-----------

#!/bin/bash

mkdir -p ~/devel/ 2>/dev/null

cd ~/devel/

git clone https://git.openwrt.org/openwrt/openwrt.git openwrt-nor-test
cd openwrt-nor-test
git checkout master
./scripts/feeds update -a
./scripts/feeds install -a
cat > .config <<EOF
CONFIG_TARGET_ath79=y
CONFIG_TARGET_ath79_generic=y
CONFIG_TARGET_ath79_generic_DEVICE_glinet_gl-ar300m-nor=y
CONFIG_ATH10K-CT_LEDS=y
CONFIG_DRIVER_11AC_SUPPORT=y
CONFIG_PACKAGE_kmod-ath10k-ct=y
CONFIG_PACKAGE_kmod-hwmon-core=y
EOF
fgrep ath10k .config
printf '\n\n=====\n\n'
cp -vp target/linux/ath79/generic/config-default target/linux/ath79/nand/
make menuconfig # and exit with save
fgrep ath10k .config



test-nand.sh
------------

#!/bin/bash

mkdir -p ~/devel/ 2>/dev/null

cd ~/devel/

git clone https://git.openwrt.org/openwrt/openwrt.git openwrt-nand-test
cd openwrt-nand-test
git checkout master
./scripts/feeds update -a
./scripts/feeds install -a
cat > .config <<EOF
CONFIG_TARGET_ath79=y
CONFIG_TARGET_ath79_nand=y
CONFIG_TARGET_ath79_nand_DEVICE_glinet_gl-ar300m-nand=y
CONFIG_ATH10K-CT_LEDS=y
CONFIG_DRIVER_11AC_SUPPORT=y
CONFIG_PACKAGE_kmod-ath10k-ct=y
CONFIG_PACKAGE_kmod-hwmon-core=y
EOF
fgrep ath10k .config
printf '\n\n=====\n\n'
cp -vp target/linux/ath79/generic/config-default target/linux/ath79/nand/
make menuconfig # and exit with save
fgrep ath10k .config



$ diff test-nor.sh test-nand.sh
7,8c7,8
< git clone https://git.openwrt.org/openwrt/openwrt.git openwrt-nor-test
< cd openwrt-nor-test
---
> git clone https://git.openwrt.org/openwrt/openwrt.git openwrt-nand-test
> cd openwrt-nand-test
14,15c14,15
< CONFIG_TARGET_ath79_generic=y
< CONFIG_TARGET_ath79_generic_DEVICE_glinet_gl-ar300m-nor=y
---
> CONFIG_TARGET_ath79_nand=y
> CONFIG_TARGET_ath79_nand_DEVICE_glinet_gl-ar300m-nand=y



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190509/3e03716e/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

More information about the openwrt-devel mailing list