[OpenWrt-Devel] [PATCH 1/7] tegra: add new target
Tomasz Maciej Nowak
tomek_n at o2.pl
Wed Mar 27 10:07:58 EDT 2019
W dniu 25.03.2019 o 23:39, Hauke Mehrtens pisze:
> Hi Tomasz,
> Soke small comments, this looks mostly ok.
>> +# CONFIG_ARM_LPAE is not set
> Is LPAE not supported by your SoC? This is needed for KVM support, but
> not all CPUs support this.
Not really sure, seems it should be enabled for all ARM v7, it was disabled in tegra_defconfig. Enabling this shouldn't do any harm, will test this.
> We normally use the ext4 driver to handle ext2.
Ack, will change to EXT4_USE_FOR_EXT2.
> Do you need ACL support?
No, will remove it.
>> +# CONFIG_JFFS2_FS is not set
> This would be needed for overlay filesystems.
I was thinking that if F2FS is enabled, it's used as overlay, will enable it.
> CONFIG_KALLSYMS should not be activated by default.
Ack, will remove it.
> Why do you need CONFIG_MANDATORY_FILE_LOCKING?
It's not needed, this is remnant of basing this config on tegra_defconfig and I didn't delve when i saw MANDATORY, will remove it.
Thank You for review, I will send v3 ASAP.
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel