[OpenWrt-Devel] [PATCH 1/2] generic: support mtd-mac-address-ascii

Petr Štetiar ynezz at true.cz
Sun Jun 9 08:35:11 EDT 2019


Yousong Zhou <yszhou4tech at gmail.com> [2019-06-08 15:54:41]:

Hi,

> It supports formats of both 001122334455 and 00:11:22:33:44:55

mtd-mac-address was rejected upstream[1], so I'm not sure if we should add new
features to it and promote its usage as it's probably going to make the switch
to the upstream provided solution harder in the future.

As mtd-mac-address was rejected, I went ahead and added NVMEM support to
of_get_mac_address[2] which was accepted and you can see already working
example in my staging tree in the wip/nvmem-mac-address branch.

In order to support MAC addresses stored in ASCII, we would probably need to
add support for multiple reg value pairs into the nvmem core as suggested by
the nvmem core maintainer[3].

On top of that, we would need to add proper support for nvmem cells[4] under
MTD partitions, because currently it doesn't work, MTD layer is simply treat
those nvmem cells as sub partitions.

> Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> ---
>  ...et-sched-Introduce-act_ctinfo-action.patch |  18 ----
>  ...et-sched-Introduce-act_ctinfo-action.patch |  20 ----
>  .../generic/hack-4.9/220-gc_sections.patch    |   2 +-

probably some leftovers from other patch?

1. https://patchwork.ozlabs.org/patch/1086628/#2154562
2. https://patchwork.ozlabs.org/project/netdev/list/?series=105972&state=*
3. https://www.spinics.net/lists/netdev/msg570314.html
4. https://lkml.org/lkml/2018/6/7/972

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list