[OpenWrt-Devel] [PATCH v2] scripts/feeds: add src-include method

Bjørn Mork bjorn at mork.no
Wed Jun 5 09:33:18 EDT 2019

John Crispin <john at phrozen.org> writes:
> On 05/06/2019 14:19, Bjørn Mork wrote:
>> The src-include method allows recursive inclusion of feeds.conf snippets.
>> This can for example be used for adding static local feeds to
>> feeds.conf.default without ever having to update the local feeds.conf:
>>   src-include defaults feeds.conf.default
>>   src-link custom /usr/local/src/lede/custom
>> Signed-off-by: Bjørn Mork <bjorn at mork.no>
>> ---
>> It would of course be nice of me if I had tested my patches, even
>> if they are only meant for discussion.
>> This version actually works.  Changes in v2:
>>   - use a variable for the file handle so we can open files recursively
>>   - match on the real 'src-include' keyword
>> Bjørn
> Hi Bjørn
> that would again involve carrying extra files around, which is what I
> am trying to avoid

Well, you can say that it replaces the command

 scripts/feeds setup -b src-link,custom,/usr/local/src/lede/custom

with the alternative command

 echo -e "src-include defaults feeds.conf.default\nsrc-link custom /usr/local/src/lede/custom" > feeds.conf


I am obviously missing your point.  I do see the problem having to
*maintain* local files.  But I don't see the problem with some static
local file which is used unmodified for every build regardless of
version. It seems much easier than maintaining additional local build
rules to generate or update that local file.

My main problem with a feeds.conf which doesn't auto-depend on
feeds.conf.default, is that it will always be stale.  Having some new
command to update it does not help me more than having cat or sed does
today.  I've found myself more than once building a development branch
with a feeds.conf generated from some released feeds.conf.default, and
vice versa.

I need a way to make sure I remember to refresh the defaults when
switching branches.  Or better: Not having to remember it.


openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list