[OpenWrt-Devel] [PATCH 01/11] tools/libaio: new package

[Thomas Petazzoni]

Hello Hauke,

I'm finally getting back to this dm-verity work, and I have a question below.

On Mon, 25 Mar 2019 18:20:09 +0100
Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

> > > diff --git a/tools/Makefile b/tools/Makefile
> > > index 9a354f6c70..9702b4df25 100644
> > > --- a/tools/Makefile
> > > +++ b/tools/Makefile
> > > @@ -27,6 +27,7 @@ tools-y += sstrip make-ext4fs e2fsprogs mtd-utils mkimage
> > >  tools-y += firmware-utils patch-image quilt padjffs2
> > >  tools-y += mm-macros missing-macros cmake scons bc findutils gengetopt patchelf
> > >  tools-y += mtools dosfstools libressl
> > > +tools-y += libaio    
> > 
> > I would prefer if this only gets build when
> > CONFIG_TARGET_ROOTFS_SQUASHFS_HASHED is set or some other config variable.  
> 
> Sure. I was a bit confused by this to be honest. Wouldn't it be
> possible to just add "cryptsetup" to tools-y when
> CONFIG_TARGET_ROOTFS_SQUASHFS_HASHED=y, and have the other packages
> (libaio, popt, lvm2) be simply built as dependencies of cryptsetup ?
> 
> Indeed, what CONFIG_TARGET_ROOTFS_SQUASHFS_HASHED=y really needs is
> cryptsetup, the rest are mere build dependencies to build cryptsetup.

Do you have some feedback on this particular question ? Ideally, I'd
like to have just:

tools-$(CONFIG_TARGET_ROOTFS_SQUASHFS_HASHED) += cryptsetup

in tools/Makefile, but I don't know in tools/cryptsetup/Makefile how to
express the dependencies it has on other tools. I briefly looked at
other tools/*/Makefile, and couldn't spot any that has a dependency on
something else.

> > > +include $(INCLUDE_DIR)/host-build.mk
> > > +
> > > +define Host/Configure
> > > +endef    
> > 
> > Is this empty configure section needed?  
> 
> Meh, most likely not. Will fix and retest.

In fact, if you look at tools/*/Makefile, there is a common pattern of
defining Host/Configure to an empty variable:

missing-macros/Makefile:define Host/Configure
missing-macros/Makefile-endef

padjffs2/Makefile:define Host/Configure
padjffs2/Makefile-endef

scons/Makefile:define Host/Configure
scons/Makefile-endef

sdimage/Makefile:define Host/Configure
sdimage/Makefile-endef

this is probably to avoid using the default Host/Configure
implementation from include/host-build.mk. But ok, in my case, using
the default implementation from include/host-build.mk, which does
nothing if there's no configure script, should work just fine.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel