[OpenWrt-Devel] [PATCH] gemini: Bring up DSA switches

Linus Walleij linus.walleij at linaro.org
Sun Jul 14 06:04:44 EDT 2019

On Sat, Jul 13, 2019 at 10:38 PM Florian Fainelli <f.fainelli at gmail.com> wrote:

> drivers/net/dsa/vitesse-vsc73xx.c returns DSA_TAG_PROTO_NONE for the
> tagging protocol, which means that the DSA slave devices are only
> control devices they are not used by the data-path (which requires an
> appropriate tagging protocol to allow differentiating the Ethernet
> frames on a per-port basis). If you supported a different tagging
> protocol, then you would not be able to enslave the DSA master device
> (eth1) into the bridge, because that would conflict with the bridge's
> rx_handler, see 8db0a2ee2c6302a1dcbcdb93cb731dfc6c0cdb5e ("net: bridge:
> reject DSA-enabled master netdevices as bridge members")

Ah it's because of this! I try to figure it out. Thanks Florian!

I really tried to figure out a way to get both the Vitesse and Realtek
switches to do internal tagging but they just don't.

The Vitesse switches can do VLAN but I just haven't implemented
it yet, but now that Adrian is using it on a Freescale board as well
I might get to it as we have some more users.

There are some patches to the kernel do do port separation using
only VLAN (by Vladimir Oltean) but of course I have to implement
VLAN first if I want to try to use that.

> Your second sequence is more in line with what you should do, see the
> recent documentation examples from Benedikt:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/dsa/configuration.rst

Oh that is really good documentation. I linked it in the Ethernet switch
page in the OpenWrt wiki.

Linus Walleij

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list