[OpenWrt-Devel] [PATCH v2] gpio-button-hotplug: mind debounce interval consistently

Christian Lamparter chunkeey at gmail.com
Sat Jul 13 21:19:52 EDT 2019

Hello David,

On Sunday, July 14, 2019 12:55:02 AM CEST David Bauer wrote:
> On 7/14/19 12:04 AM, Christian Lamparter wrote:
> > The "goto set_setstate;" only happens if state = 0 (Which in gpio-button
> > context means) that the button is in an unpressed state.
> Okay, you are right, this is one thing i missed.
> If we suspect, the polarity is correctly set for every board, your code is completely
> right and should behave the same for polled and irq based keys.
> So, the question is primarily if we want a event if a button is pressed continuously
> on bootup. I think this is the point where our expectations differ.
> I might be a bit late for this realization, sorry for that :D

Yes, that's something that would deserve to get mentioned.

More information about the openwrt-devel mailing list