[OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

Jo-Philipp Wich jow at openwrt.org
Wed Jan 30 05:32:32 EST 2019


> That is true. But, on the other hand, the same routine was not printing
> anything if IS_TTY is not 1. I would say that this is unexpected
> behaviour too. If the log file shows some error, it would be nice to see
> what part was being processed.

this might be, but the scope of this patch was to make the build system
recognize `NO_COLOR` in order to suppress output coloring, so the
implementation of this feature should do exactly that.

> I do not really mind how it is fixed, so long NO_COLOR is honoured.
> Otherwise, I would have to find some script that filters ANSI colour
> codes and the like.

Could you please send a V2 with the requested change to print $(1)
without ANSII escape sequences?

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190130/f220d921/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list