[OpenWrt-Devel] [PATCH 4/4 v2] gemini: Add SL93512R Support

[Linus Walleij]

Hi Christian!

thanks for tidying up Gemini!

On Thu, Jan 24, 2019 at 4:21 PM Christian Lamparter <chunkeey at gmail.com> wrote:

> > +     cp $(IMAGE_KERNEL) $(BIN_DIR)/zImage
> > +     mv $(BIN_DIR)/rd.gz $(BIN_DIR)/$(IMG_PREFIX)-sl93512r-rd.gz
> > +     mv $(BIN_DIR)/hddapp.bz2 $(BIN_DIR)/$(IMG_PREFIX)-sl93512r-hddapp.bz2
> > +     mv $(BIN_DIR)/zImage $(BIN_DIR)/$(IMG_PREFIX)-sl93512r-zImage
> > +endef
>
> I did rework the image creation process for the NAS4220B and sq201
> because it was very racy (and probably caused some of the build
> failures in this target? [0]) and I think it should be possible to
> improve the sl93512r as well.

Yup I rebased my SL93512r on top of your changes, it works
like a charm.

> > +define Device/sl93512r
> > +     DEVICE_TITLE := StorLink SL93512R Reference Design
>
> > +     IMAGES += sl93512r-image
> > +     IMAGE/sl93512r-image := sl93512r-images
> Can you please check if something like this:
>
> ARTIFACTS := zImage
> ARTIFACT/zImage := append-kernel
> IMAGES := rd.gz hddapp.bz2
> IMAGE/rd.gz := append-rootfs | pad-to 6144k
> IMAGE/hddapp.bz2 := pad-extra 6144k | append-rootfs
>
> Produces similar/compatible files?
> (This would make the extra Build/sl93512r-images obsolete).

It does, I have a new patch for this.

I will not submit it again until we switch to v4.19
though, just sending the kernel patches and
config-v4.19 for next iteration.

Yours,
Linus Walleij

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel