[OpenWrt-Devel] [PATCH] treewide: dts: Unify naming of gpio-keys nodes

Petr Štetiar ynezz at true.cz
Tue Jan 22 15:52:41 EST 2019

Christian Lamparter <chunkeey at gmail.com> [2019-01-22 17:54:13]:


> The at91, apm821xx, ipq40xx, ipq806x, layerscape and oxnas are probably
> ready to be merged.

a lot of additional work, thanks!

> The situation with ramips, ath79 and lantiq is a bit more complicated:
> <https://git.openwrt.org/?p=openwrt/staging/chunkeey.git;a=commit;h=784c3a84edc30d801a4c06c8ab5a551a95aadbb2>
> <https://git.openwrt.org/?p=openwrt/staging/chunkeey.git;a=commit;h=2dd5806aa930199cf3fc72231bf802d9789011a4>
> because some of these devices also have a separated ath9k-leds 
> and in theory these nodes "could be merged". However, this is
> going to be a bad idea and so I left the "gpio-leds" in these cases
> as is. Maybe "soc-leds" could be a better name, but I don't think
> upstream will care much about that.

I've noticed those during my sed session as well, but checked those manualy
and it looked fine, but maybe I've overlooked something, sorry for that.

> Feedback for merging patches upstream or into openwrt? For upstream:
> Have you talked to Rob or Mark? Usually, they do review device-tree
> changes related to drivers and suchs relatively quickly. 

Nope, the patch was sent just a few days ago (December 16th), so for me it's
still too early trying to ping someone about it.

> However, something must have caused them to ignore the default-state = off
> patch. I can't even find it in the devicetree patchwork. maybe it was too
> big?

It's hidden here https://patchwork.kernel.org/patch/10732469/ even with 'To:
devicetree at vger.kernel.org' header, so maybe the patchwork/mail pipeline

> Why not start there? Upstream has a accumulated a vast library of semantic
> patches (http://coccinelle.lip6.fr/) and from what I can tell, these have 
> a pretty good track record to get accepted. (I guess the main difficulty here
> will be to check whenever spatch already supports dts/dtsi files or not).

Nice tool, but still without DT support.

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list