[OpenWrt-Devel] [PATCH] build: Fix missing device variables for artifacts

Petr Štetiar ynezz at true.cz
Fri Jan 18 03:25:59 EST 2019

It was reported to me today on IRC, that building of artifacts doesn't
work properly if the concat_cmd references DEVICE_NAME variable. I've
found out, that it's due to missing call of Device/Export in artifacts
building code path, so this patch adds the missing Device/Export call
which in turn exports DEFAULT_DEVICE_VARS into the artifacts

Fixes: 493c9a35516c ("build: Introduce building of artifacts")
Tested-by: Oskari Lemmela <oskari at lemmela.net>
Reported-by: Oskari Lemmela <oskari at lemmela.net>
Signed-off-by: Petr Štetiar <ynezz at true.cz>
 include/image.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/image.mk b/include/image.mk
index a2b106d..55ee4ef 100644
--- a/include/image.mk
+++ b/include/image.mk
@@ -501,6 +501,7 @@ endef
 define Device/Build/artifact
   $$(_TARGET): $(BIN_DIR)/$(IMAGE_PREFIX)-$(1)
+  $(eval $(call Device/Export,$(KDIR)/tmp/$(IMAGE_PREFIX)-$(1)))
 	@rm -f $$@
 	$$(call concat_cmd,$(ARTIFACT/$(1)))

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list