[OpenWrt-Devel] [PATCH 2/2] mvebu: remove default profile

[Rosen Penev]

On Wed, Jan 16, 2019 at 11:51 PM Mathias Kresin <dev at kresin.me> wrote:
>
> 17/01/2019 05:38, Rosen Penev:
> > On Sun, Jan 13, 2019 at 12:28 PM Tomasz Maciej Nowak <tomek_n at o2.pl> wrote:
> >>
> >> When using Image Builder and building image for Cortex A53 or
> >> A72 subtargets, it'll fail with following message:
> >>
> >> Collected errors:
> >>   * opkg_install_cmd: Cannot install package mwlwifi-firmware-88w8864.
> >>   * opkg_install_cmd: Cannot install package mwlwifi-firmware-88w8964.
> >> make[2]: *** [Makefile:153: package_install] Error 255
> >> make[1]: *** [Makefile:114: _call_image] Error 2
> >>
> >> This is beacuse both packages are available only for Cortex A9 subtarget
> >> and are included in PACKAGES array in default profile. Instead patching
> >> this, let's remove profiles completely, since all necessary packages are
> >> specified in DEVICE_PACKAGES array for each device.
> > NACK. This breaks Turris Omnia compilation. Something about a clearfog
> > bootloader.
>
> Would you please try to add the "PROFILES := Default" again to the
> "define Device/Default" section and check if it fixes your build error?
That fixes it.
>
> On gemini, I noticed that due to the missing PROFILES all images are
> build, regardless of the selected (or currently processed in case of a
> multi profile build).
>
> It causes race conditions on gemini and is most likely the reason why
> the buildbot fails to create the images for the last weeks.
>
> I'm not yet sure where the real bug is.
>
> Mathias
>
> >>
> >> Signed-off-by: Tomasz Maciej Nowak <tomek_n at o2.pl>
> >> ---
> >>   target/linux/mvebu/image/Makefile          |  1 -
> >>   target/linux/mvebu/profiles/000-Default.mk | 18 ------------------
> >>   2 files changed, 19 deletions(-)
> >>   delete mode 100644 target/linux/mvebu/profiles/000-Default.mk
> >>
> >> diff --git a/target/linux/mvebu/image/Makefile b/target/linux/mvebu/image/Makefile
> >> index be01623e86..22519bd9d0 100644
> >> --- a/target/linux/mvebu/image/Makefile
> >> +++ b/target/linux/mvebu/image/Makefile
> >> @@ -81,7 +81,6 @@ define Build/omnia-medkit-initramfs
> >>   endef
> >>
> >>   define Device/Default
> >> -  PROFILES := Default
> >>     DEVICE_DTS := $(1)
> >>     BOARD_NAME = $$(DEVICE_DTS)
> >>     KERNEL_NAME := zImage
> >> diff --git a/target/linux/mvebu/profiles/000-Default.mk b/target/linux/mvebu/profiles/000-Default.mk
> >> deleted file mode 100644
> >> index 8690dd8da5..0000000000
> >> --- a/target/linux/mvebu/profiles/000-Default.mk
> >> +++ /dev/null
> >> @@ -1,18 +0,0 @@
> >> -#
> >> -# Copyright (C) 2015 OpenWrt.org
> >> -#
> >> -# This is free software, licensed under the GNU General Public License v2.
> >> -# See /LICENSE for more information.
> >> -#
> >> -
> >> -define Profile/Default
> >> -       NAME:=Default Profile (all drivers)
> >> -       PACKAGES:= kmod-mwlwifi wpad-basic swconfig mkf2fs e2fsprogs \
> >> -                  mwlwifi-firmware-88w8864 mwlwifi-firmware-88w8964
> >> -endef
> >> -
> >> -define Profile/Default/Description
> >> -       Default package set compatible with most boards.
> >> -endef
> >> -
> >> -$(eval $(call Profile,Default))
> >> --
> >> 2.20.1
> >>
> >>
> >> _______________________________________________
> >> openwrt-devel mailing list
> >> openwrt-devel at lists.openwrt.org
> >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> >
> > _______________________________________________
> > openwrt-devel mailing list
> > openwrt-devel at lists.openwrt.org
> > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> >
>

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel