[OpenWrt-Devel] [PATCH] treewide: dts: Unify naming of gpio-keys nodes

Petr Štetiar ynezz at true.cz
Tue Jan 1 12:07:40 EST 2019

Christian Lamparter <chunkeey at gmail.com> [2018-12-31 17:41:34]:

> I hope you know what you are up against because unless you also do the changes
> upstream this will happen again and again. :\ / :)

My plan is to first wait for comments here, see if it gets merged eventualy
and then start poking upstream. I still didn't received any feedback yet(good
sign?) on my last `treewide: dts: Remove default-state=off property...`[1]
upstream attempt so I don't know if it's worth the effort.

Anyway, I guess, that in most of the cases, people are just copy&pasting from
the DTS files from the OpenWrt repository and some of them even wonder[2] why
they need to use generic `leds` node names if it's not the case in the rest of
the DTS files in OpenWrt tree:

 @mkresin: would you please rename the node to the generic "leds".
 @arapov: @mkresin, by the way, the rest of *.dts in ramips/ using gpio-leds.
          Do you still think it is good to deviate from the rest here?

1. https://patchwork.kernel.org/patch/10732465/
2. https://github.com/openwrt/openwrt/pull/1686#discussion_r244512451
3. https://openwrt.org/submitting-patches#dts_checklist

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list