[OpenWrt-Devel] [PATCH] libevent2: Add -Wl, --gc-sections to reduce size a little.

[Petr Štetiar]

Rosen Penev <rosenp at gmail.com> [2019-02-19 22:45:37]:

> On Tue, Feb 19, 2019 at 10:19 PM Petr Štetiar <ynezz at true.cz> wrote:
> >
> > Rosen Penev <rosenp at gmail.com> [2019-02-19 13:01:57]:
> >
> > > -TARGET_CFLAGS += $(FPIC)
> >
> > Why did you removed this? I can see, that you've added --with-pic configure
> > option, but I'm wondering if it's going to provide same result on all
> > platforms.
>
> Don't see why not. it adds fPIC and dPIC

Just that there's following in rules.mk:

 ifeq ($(ARCH),powerpc)
   FPIC:=-fPIC
 else
   FPIC:=-fpic
 endif

so let's hope it's handled properly in autofoo stuff.

> > > +     --disable-libevent-regress \
> >
> > I'm wondering how this might reduce the binary size. It might be enabled by
> > default for some reason, so I'm not sure if disabling regression tests for
> > saving some build time (BTW how much?) is a good idea.
>
> Seems to also be done elsewhere.

Ok, what does it mean elsewhere? Why do you think, that it's a good idea to
disable the regression tests which might be actually a poor man's Q&A during
toolchain/binutils bumps.  Isn't it better to catch any potential issues
during build phase, then later on the device?

> > You've forget to add on which platforms you've build and run tested this
> > change, and mainly on which platform you're seeing this 4KB size reduction.
>
> ramips. I doubt it's much different elsewhere.

I would expect, that you've at least tried to build all the packages which
depends on the libevent2, and ideally tried to run them as well. The list
isn't that small:

package/network/services/lldpd admin/zabbix lang/php7-pecl-http
lang/php7-pecl-libevent libs/libevhtp net/addrwatch net/memcached
net/nfs-kernel-server net/ntpd net/ratechecker net/redsocks net/seafile-ccnet
net/seafile-server net/sstp-client net/tor net/transmission sound/forked-daapd
utils/tmux

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel