[OpenWrt-Devel] [PATCH 5/8 v3] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf

Linus Walleij linus.walleij at linaro.org
Sun Feb 17 15:57:36 EST 2019


On Sun, Feb 17, 2019 at 7:16 PM Sasha Levin <sashal at kernel.org> wrote:
> On Thu, Feb 14, 2019 at 02:24:00PM +0100, Linus Walleij wrote:
> >From: Rafał Miłecki <rafal at milecki.pl>
> >
> >commit 854826c9d526fd81077742c3b000e3f7fcaef3ce upstream.
> >
> >Values of these fields are set during init and never modified. They are
> >used (read) in a single function only. There isn't really any reason to
> >keep them in a struct. It only makes struct just a bit bigger without
> >any visible gain.
> >
> >Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
> >Reviewed-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> >Signed-off-by: Richard Weinberger <richard at nod.at>
> >Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
>
> This one is a cleanup, why is it needed in -stable?

I suppose just a prerequisite for 6/8 which was a feature,
so let's drop this one too.

Thanks!
Linus Walleij

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list