[OpenWrt-Devel] [PATCH 1/2] scripts/strip-kmod.sh: Replace legacy `` with $()

mail at adrianschmutzler.de mail at adrianschmutzler.de
Tue Dec 31 05:36:01 EST 2019


> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Rosen Penev
> Sent: Dienstag, 31. Dezember 2019 03:18
> To: openwrt-devel at lists.openwrt.org
> Subject: [OpenWrt-Devel] [PATCH 1/2] scripts/strip-kmod.sh: Replace legacy
> `` with $()

Thanks for taking care of those issues.

Some comments for future submissions:
- Based on the submitting-patches rules the first word after the prefix in commit title has to be lower case (for this patch "Replace" -> "replace")
- If you change something in a target folder, the first prefix should be the name of the target ("mvebu:", "ramips:", etc.; not applicable to this patch). Maybe have a quick look at the relevant section of submitting-patches; I changed that manually when applying your last set of patches
- Even with simple changes like this one, it would be nice to have a one-sentence description _why_ they are needed.
- Finally, personally, I tend to prevent having special characters in the commit title. Thus, I would prefer using the word "backticks" instead of putting "``" directly into the commit title.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191231/63a04b52/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list