[OpenWrt-Devel] [PATCH] [19.07] ramips: rename DIR-860L entries according to the new manufacturer / device spec

mail at adrianschmutzler.de mail at adrianschmutzler.de
Thu Dec 26 18:11:34 EST 2019


> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Stijn Segers
> Sent: Mittwoch, 25. Dezember 2019 15:39
> To: openwrt-devel at lists.openwrt.org
> Subject: [OpenWrt-Devel] [PATCH] [19.07] ramips: rename DIR-860L entries
> according to the new manufacturer / device spec
> Most images follow the openwrt-target-subtarget-manufacturer-device
> naming specification, but the D-Link DIR-860L rev B1 does not. This patch
> brings it in line.
> Master had this updated a while ago, it's okay there.

Though I'm a big fan of unification and made an effort to have this sorted out in master, I do not think backporting those device name changes is very helpful. This will create additional work, but effectively it will just move the "break" from 19.07/master to 18.06/19.07.

As a cosmetic issue, it wouldn't be a candidate for backporting under normal circumstances, too.

For further reasoning/discussion, refer to the following PR in GitHub, where the same question has already been discussed a month ago:


I will mark this PR as Rejected, I hope you accept my arguments and continue to submit contributions in the future.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191227/0990e0f5/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list