[OpenWrt-Devel] [RFC][PATCH] base-files: send informational UDP message each second waiting

Paul Fertser fercerpav at gmail.com
Wed Dec 11 06:03:53 EST 2019


On Tue, Dec 10, 2019 at 03:42:13PM +0100, Petr Štetiar wrote:
> Paul Fertser <fercerpav at gmail.com> [2019-12-10 17:24:20]:
> > in cases when the interface is brought up faster it leads to two messages
> in cases when the interface is brought up slower it leads to no message.
> To me it just seems like a workaround to fix your use case, not a proper fix.

You're right, I mentioned "inherently racy" in the commit message
exactly because of that.

Waiting for LOWER_UP there without a timeout is not a solution because
in the normal bootup case there might be nothing attached to the LAN
so the boot will be effectively halted forever. Waiting with a timeout
poses a question of what that timeout should be set to; and if that's
reasonable to extend current 2 seconds with any significant amount.

Current documentation says a message should be sent. Current code
works for some devices and fails for other devices. My patch improves
the situation without adding any code complexity (indeed, it's even
removing one line) or wasting boot time.

Do you have any other possible solution in mind?

Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav at gmail.com

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list