[OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

[Adrian Schmutzler]

Hi,

> +    lna0 {

is there a scheme for proper names already?

While I do not have an opinion for lnaX, I'd prefer "usb_power"/"usb0_power" over just "usb"/"usb0".

> +        gpio-hog;
> +        line-name = "tp-link:ext:lna0";
> +        gpios = <18 GPIO_ACTIVE_HIGH>;

At least for lnaX, so far "0" (e.g. "gpios = <18 0>;") has been used instead of GPIO_ACTIVE_HIGH. Is there a preference for one of the options?

> +        output-high;
> +    };

Best

Adrian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190807/c5c4c9bf/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel