[OpenWrt-Devel] [PATCH 1/2] scripts/qemustart: no-network by default and enable with -n
yszhou4tech at gmail.com
Thu Apr 25 11:40:32 EDT 2019
On Thu, 25 Apr 2019 at 23:05, Hans Dedecker <dedeckeh at gmail.com> wrote:
> Hi Yousong,
> On Thu, Apr 25, 2019 at 4:29 PM Yousong Zhou <yszhou4tech at gmail.com> wrote:
> > Before this change, we have no way to have network on as both bash and
> > zsh have zero exit status for "[ -n ]" and "[ -z ]"
> > By running qemu without network by default we make common usage of and
> > first encounter with qemustart script more comfortable. With networking
> > only two characters argument away.
> > Cc: Petr Štetiar <ynezz at true.cz>
> > Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> > ---
> > scripts/qemustart | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> I pushed a patch
> yesterday which fixes the [ -n ] and [ -z ] issues
I missed that one ;) But I would still like to propose that we make
"no network" the default. I assume that would be easier to set up and
works for most cases. What do you think?
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel