[OpenWrt-Devel] [PATCH 1/2] base-files: improve lib/upgrade/common.sh

Klaus Kudielka klaus.kudielka at gmail.com
Wed Apr 24 13:28:07 EDT 2019

On 24.04.19 17:29, Tomasz Maciej Nowak wrote:
> Hi Klaus.
> W dniu 23.04.2019 o 21:59, Klaus Kudielka pisze:
>> Recently, upgrade device autodetection has been added to the mvebu target.
>> This exposes some shortcomings of the generic export_bootdevice function,
>> e.g. on the Turris Omnia: export_bootdevice silently reports the root
>> partition to be the boot device. This makes the sysupgrade process
>> fail at several places.
>> Fix this by clearly distinguishing between /proc/cmdline arguments which
>> specify the boot disk, and those which specify the root partition. Only
>> in the latter case, strip off the partition. Include /dev/mmcblk* and
>> /dev/sd* as potential arguments to "root=".
> When we discussed this change I forgot to mention that this would break sysupgrade
> on several targets:
> apm821xx,
> brcm2708,
> omap,
> sunxi,
> because their upgrade/platform.sh would assume old behavior. So this patch would
> need additional changes in platform.sh for those targets. They should be
> straightforward, as example You can compare sunxi to tegra on what differs.
Ouch. Different behaviour, depending on how the rootfs is specified.
Well, I guess I'll make an update then.
>> Fixes 4e8345ff68 ("mvebu: base-files: autodetect upgrade device")
> Add colon after Fixes, that way patchwork will pick it up.

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list