[OpenWrt-Devel] [PATCH/netifd] interface: fix "if-down" hotplug event handling

Martin Schiller ms at dev.tdt.de
Thu Apr 11 09:02:40 EDT 2019


commit a97297d83e42 ("interface: set interface in TEARDOWN state when checking link state")
broke the if-down hotplug event handling, as the iface->state is now IFS_TEARDOWN when
calling the mark_interface_down() function from the IFPEV_DOWN event.

Fixes: a97297d83e42 ("interface: set interface in TEARDOWN state when checking link state")
Signed-off-by: Martin Schiller <ms at dev.tdt.de>
---
 interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/interface.c b/interface.c
index fd7a826..7c25839 100644
--- a/interface.c
+++ b/interface.c
@@ -268,7 +268,7 @@ mark_interface_down(struct interface *iface)
 	iface->link_up_event = false;
 	iface->state = IFS_DOWN;
 	switch (state) {
-	case IFS_UP:
+	case IFS_TEARDOWN:
 		interface_event(iface, IFEV_DOWN);
 		break;
 	case IFS_SETUP:
-- 
2.11.0


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list