[OpenWrt-Devel] [PATCH 0/2] ar71xx: Add support for Bullet M (XW)

Petr Štetiar ynezz at true.cz
Tue Apr 2 09:15:15 EDT 2019


Adrian Schmutzler <mail at adrianschmutzler.de> [2019-04-02 14:07:39]:

Hi,

> > # UBNT_CHIP e.g. one of (ar7240, ar933x, ar934x)
> > +# UBNT_VERSION e.g. one of (6.0.0, 8.5.0)

 define Device/ubnt
  UBNT_VERSION := 6.0.0

so it defaults to version 6.0.0 as it's used now, but it could be overriden if
the board needs to, like for example `ubnt-xw` variant:

 define Device/ubnt-xw
  UBNT_VERSION := 6.0.4

> Maybe include the 6.0.4 in the commented list of versions, depending on how literally you take the "e.g."

I've just backported it as it is in ath79 now, and I see no point to update
comment each time we add new version :-) I think, that it's there mainly as an
example of usage, rather then documentation for this variable.

Or do you find it as it is somehow misleading or unclear?

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list